Add RSpec example to test for missing links on people pages #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldavidson
force-pushed
the
add-spec-for-disappearing-role-appt-links
branch
from
c6e7d9b
to
c60e428
Compare
…us PR #1069 and resulting in an incident
aldavidson
force-pushed
the
add-spec-for-disappearing-role-appt-links
branch
from
c60e428
to
1bd2ca1
Compare
JonathanHallam
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging previous PR #1069, we found that some of the Hash normalisation introduced meant that nested links two levels down lost their content, and this resulted in an incident.
All the tests passed on that PR, which means this scenario was not covered by tests - so this PR adds an explicit test case using the JSON from an actual content_item from integration against which the problem was identified.
Trello card
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.