Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AB test to request new Explore supermenu header from Static #2827

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Add AB test to request new Explore supermenu header from Static #2827

merged 2 commits into from
Jul 19, 2021

Conversation

chao-xian
Copy link
Contributor

@chao-xian chao-xian commented Jun 16, 2021 •
edited
Loading

Static has a new header that the GOV.UK Explore team want to AB test as part of their beta.

See alphagov/static#2540

Trello https://trello.com/c/LUhrajXF/323-prepare-the-new-menu-a-b-test-for-sections-of-govuk

Visual changes

Screen.Recording.2021-06-16.at.13.40.28.mov

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@bevanloon bevanloon temporarily deployed to govuk-fronte-ab-test-he-lautlt June 16, 2021 16:17 Inactive
@chao-xian chao-xian mentioned this pull request Jun 16, 2021
Merged
@chao-xian chao-xian marked this pull request as ready for review June 16, 2021 16:54
@chao-xian chao-xian changed the title Add AB test to request new Explore supermenu header from Static [DO NOT MERGE] Add AB test to request new Explore supermenu header from Static Jun 21, 2021
@chao-xian
Copy link
Contributor Author

chao-xian commented Jun 21, 2021 •
edited
Loading

This now needs to be amended to accommodate #2802

@chao-xian chao-xian force-pushed the ab-test-header branch 3 times, most recently from 4a914fe to e5c3fe9 Compare June 22, 2021 14:39
@chao-xian chao-xian marked this pull request as draft July 1, 2021 12:57
@chao-xian chao-xian changed the title [DO NOT MERGE] Add AB test to request new Explore supermenu header from Static Add AB test to request new Explore supermenu header from Static Jul 6, 2021
@chao-xian chao-xian marked this pull request as ready for review July 6, 2021 17:31
@chao-xian chao-xian requested a review from alex-ju July 8, 2021 14:58
alex-ju
alex-ju approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆎

sihugh
sihugh previously requested changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@sihugh sihugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good, but I spotted a couple of issues

app/views/local_transaction/search.html.erb Outdated Show resolved Hide resolved
app/views/place/show.html.erb Outdated Show resolved Hide resolved
@chao-xian
Add AB test to request new Explore supermenu header from Static
2bee8b2 
Static has a new header that the GOV.UK Explore team want to AB test as part of their beta.
@chao-xian
Update templates to set header for Explore AB Test
a7dc4a6 
Static has a new header that the GOV.UK Explore team want to AB test as part of their beta.
@chao-xian chao-xian merged commit 45e99d2 into main Jul 19, 2021
@chao-xian chao-xian deleted the ab-test-header branch July 19, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-ju alex-ju alex-ju approved these changes

@sihugh sihugh sihugh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chao-xian @sihugh @alex-ju @bevanloon