Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explore_header templates #2515

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Add explore_header templates #2515

merged 2 commits into from
Jul 6, 2021

Conversation

chao-xian
Copy link
Contributor

@chao-xian chao-xian commented Jun 16, 2021

This will allow us to switch between the current header menu and the newer design that we want to AB test with. This means that frontend apps using the AB Test gem can request a different template via Slimmer.

See alphagov/government-frontend#2156 for example

Trello https://trello.com/c/LUhrajXF/323-prepare-the-new-menu-a-b-test-for-sections-of-govuk

@bevanloon bevanloon temporarily deployed to govuk-static-ab-test-he-mxl9zt June 16, 2021 16:53 Inactive
@chao-xian chao-xian marked this pull request as ready for review June 16, 2021 16:54
@bevanloon bevanloon temporarily deployed to govuk-static-ab-test-he-mxl9zt June 21, 2021 12:28 Inactive
@chao-xian chao-xian changed the title Add core_layout_explore_header template [DO NOT MERGE] Add core_layout_explore_header template Jun 21, 2021
@chao-xian
Copy link
Contributor Author

chao-xian commented Jun 21, 2021

This now needs to be amended to accommodate alphagov/frontend#2802 Splitting work to AB test for apps using gem_layout into a future update.

@bevanloon bevanloon temporarily deployed to govuk-static-ab-test-he-mxl9zt June 21, 2021 17:28 Inactive
@chao-xian chao-xian changed the title [DO NOT MERGE] Add core_layout_explore_header template Add core_layout_explore_header template Jun 22, 2021
@chao-xian chao-xian force-pushed the ab-test-header branch 3 times, most recently from af490d0 to cc7fc79 Compare July 2, 2021 14:09
@chao-xian chao-xian changed the title Add core_layout_explore_header template Add explore_header templates Jul 2, 2021
This will allow us to switch between the current header menu and the newer design that we want to AB test with. This means that frontend apps using the AB Test gem can request a different template via Slimmer.
@chao-xian chao-xian merged commit a2cf45a into main Jul 6, 2021
@chao-xian chao-xian deleted the ab-test-header branch July 6, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants