Move case studies routes #4372
Open
Move case studies routes #4372
+806
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georges1996
force-pushed
the
move-case-studies-pages
branch
from
4b79f76
to
5736b90
Compare
georges1996
force-pushed
the
move-case-studies-pages
branch
from
dbc0da6
to
f4d9f5d
Compare
georges1996
force-pushed
the
move-case-studies-pages
branch
from
aee5af8
to
6d4592f
Compare
georges1996
force-pushed
the
move-case-studies-pages
branch
from
6d4592f
to
40db71b
Compare
georges1996
force-pushed
the
move-case-studies-pages
branch
from
40db71b
to
a368c2c
Compare
georges1996
force-pushed
the
move-case-studies-pages
branch
from
e8d36b1
to
0d5579a
Compare
georges1996
force-pushed
the
move-case-studies-pages
branch
from
0d5579a
to
dc0a31b
Compare
georges1996
force-pushed
the
move-case-studies-pages
branch
from
dc0a31b
to
637866e
Compare
georges1996
force-pushed
the
move-case-studies-pages
branch
from
637866e
to
d196c65
Compare
georges1996
force-pushed
the
move-case-studies-pages
branch
from
d196c65
to
4cd21ec
Compare
georges1996
force-pushed
the
move-case-studies-pages
branch
from
46cbb38
to
d7b8472
Compare
Commit audit trail: - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/app/presenters/content_item/withdrawable.rb - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/test/presenters/content_item/withdrawable_test.rb
…e studies Commit audit trail: - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/app/presenters/content_item_presenter.rb - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/test/presenters/content_item_presenter_test.rb - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/app/helpers/application_helper.rb - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/test/helpers/application_helper_test.rb
- To use the Withdrawable concern - To expose first_published_at and first_public_at attributes
Commit audit trail: - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/app/presenters/case_study_presenter.rb - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/app/views/content_items/case_study.html.erb - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/test/integration/case_study_test.rb - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/test/presenters/case_study_presenter_test.rb - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/config/routes.rb
Using govuk-docker-run rake "consolidation:copy_translation[content_item.schema_name.case_study]" we port over the case_study translations and change it to be under our new yaml structure Audit trail: - https://github.com/alphagov/government-frontend/tree/0aee348d51cebacd5344115f2ca02bdb17095249/config/locales
georges1996
force-pushed
the
move-case-studies-pages
branch
from
d7b8472
to
aa1cd27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR #4379 needs to be merged in and this will need to be rebased to fix the case studies which have translations e.g https://www.gov.uk/government/case-studies/doing-business-in-spain
What
Handle Case Studies documents in Frontend, in preparation for them being taken out of Government Frontend
Why
Ticket: https://trello.com/c/ybpXwp34/368-move-document-type-casestudy-from-government-frontend-to-frontend
How
By moving the routes and necessary code to get the pages rendering in the frontend application
Screenshots?
Frontend
Gov-Frontend