-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move case studies routes #4372
Open
georges1996
wants to merge
11
commits into
main
Choose a base branch
from
move-case-studies-pages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Move case studies routes #4372
Commits on Nov 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 23bed01 - Browse repository at this point
Copy the full SHA 23bed01View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2b54a4 - Browse repository at this point
Copy the full SHA b2b54a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fcbf64 - Browse repository at this point
Copy the full SHA 3fcbf64View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb19eab - Browse repository at this point
Copy the full SHA eb19eabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e52453 - Browse repository at this point
Copy the full SHA 3e52453View commit details -
Add Withdrawable concern and tests
Commit audit trail: - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/app/presenters/content_item/withdrawable.rb - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/test/presenters/content_item/withdrawable_test.rb
Configuration menu - View commit details
-
Copy full SHA for 035b068 - Browse repository at this point
Copy the full SHA 035b068View commit details -
Add various locale and translations methdods to deal with foreign cas…
…e studies Commit audit trail: - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/app/presenters/content_item_presenter.rb - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/test/presenters/content_item_presenter_test.rb - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/app/helpers/application_helper.rb - https://github.com/alphagov/government-frontend/blob/a938e4bee78b794e4e5303a1bde1dfd05e94b287/test/helpers/application_helper_test.rb
Configuration menu - View commit details
-
Copy full SHA for bb54106 - Browse repository at this point
Copy the full SHA bb54106View commit details -
- To use the Withdrawable concern - To expose first_published_at and first_public_at attributes
Configuration menu - View commit details
-
Copy full SHA for 3861ce4 - Browse repository at this point
Copy the full SHA 3861ce4View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcb770d - Browse repository at this point
Copy the full SHA dcb770dView commit details -
Add case studies model, controller, presenter, route and tests
Commit audit trail: - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/app/presenters/case_study_presenter.rb - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/app/views/content_items/case_study.html.erb - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/test/integration/case_study_test.rb - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/test/presenters/case_study_presenter_test.rb - https://github.com/alphagov/government-frontend/blob/0aee348d51cebacd5344115f2ca02bdb17095249/config/routes.rb
Configuration menu - View commit details
-
Copy full SHA for 47b38d0 - Browse repository at this point
Copy the full SHA 47b38d0View commit details -
Using govuk-docker-run rake "consolidation:copy_translation[content_item.schema_name.case_study]" we port over the case_study translations and change it to be under our new yaml structure Audit trail: - https://github.com/alphagov/government-frontend/tree/0aee348d51cebacd5344115f2ca02bdb17095249/config/locales
Configuration menu - View commit details
-
Copy full SHA for aa1cd27 - Browse repository at this point
Copy the full SHA aa1cd27View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.