Remove unnecessary dependencies from Whitehall and Smart Answers #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We think at one point the layouts for admin apps were in Static (as well as it rendering frontend pages). This is no longer the case, and Whitehall shouldn't have a dependency on Static, just as the other publishing apps do not.
Smart Answers makes requests to `/api/content/world`, which used to be a Whitehall API. This is no longer the case: alphagov/whitehall#7941
ChrisBAshton
force-pushed
the
update-dependencies
branch
from
c60ee3b
to
d886036
Compare
GDSNewt
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion at https://gds.slack.com/archives/CAB4Q3QBW/p1722266127332699