Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary dependencies from Whitehall and Smart Answers #784

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Remove unnecessary dependencies from Whitehall and Smart Answers #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ae26c7
Remove 'Static' dependency from Whitehall
ChrisBAshton Oct 1, 2024
d886036
Remove 'Whitehall' dependency from Smart Answers
ChrisBAshton Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/smart-answers/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
smart-answers: bundle-smart-answers publishing-api content-store static whitehall
smart-answers: bundle-smart-answers publishing-api content-store static
$(GOVUK_DOCKER) run $@-lite yarn
2 changes: 0 additions & 2 deletions projects/smart-answers/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ services:
- publishing-api-app
- static-app
- content-store-app
- whitehall-app
environment:
GOVUK_PROXY_STATIC_ENABLED: "true"
VIRTUAL_HOST: smart-answers.dev.gov.uk
Expand All @@ -43,7 +42,6 @@ services:
- publishing-api-app
- static-app
- content-store-app
- whitehall-app
environment:
GOVUK_PROXY_STATIC_ENABLED: "true"
VIRTUAL_HOST: smart-answers.dev.gov.uk
Expand Down
2 changes: 1 addition & 1 deletion projects/whitehall/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
whitehall: bundle-whitehall asset-manager publishing-api static
whitehall: bundle-whitehall asset-manager publishing-api
$(GOVUK_DOCKER) run $@-lite bin/rake db:prepare
$(GOVUK_DOCKER) run $@-lite env RAILS_ENV=test bin/rake db:prepare
$(GOVUK_DOCKER) run $@-lite yarn
1 change: 0 additions & 1 deletion projects/whitehall/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ services:
depends_on:
- mysql-8
- redis
- static-app
- nginx-proxy
- asset-manager-app
- publishing-api-app
Expand Down