Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update review app examples #5088

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Update review app examples #5088

merged 5 commits into from
Jul 26, 2024

Conversation

querkmachine
Copy link
Member

@querkmachine querkmachine commented Jun 18, 2024

We want to merge these changes into our main branch so that we can use them for ongoing testing and future audits, without having to reproduce them anew.

For #5085.

Changes

  • Adds headings to the Tabs panels in 'Start page' example.
  • Adds a second Password input to the 'Update your account details' example.
    • Each has customised ARIA labels and screen reader text unique to each input.
    • Adds validation that checks that both inputs have the same value.
  • Adds 'Make a payment' example for testing Text inputs with prefixes and related validation styles.
  • Modify the 'Search' example to make it appear to be the second page of results, so that the previous link is visible in Pagination.
  • Remove Exit This Page component configuration from Child Maintenance example, as these were repeating the default values.

Copy link

github-actions bot commented Jun 18, 2024

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 112.52 KiB
dist/govuk-frontend-development.min.js 41.88 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 87.42 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 82.11 KiB
packages/govuk-frontend/dist/govuk/all.mjs 981 B
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 112.51 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 41.87 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB
packages/govuk-frontend/dist/govuk/init.mjs 4.86 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 79.24 KiB 39.84 KiB
accordion.mjs 23.5 KiB 12.39 KiB
button.mjs 5.98 KiB 2.69 KiB
character-count.mjs 22.4 KiB 9.92 KiB
checkboxes.mjs 5.83 KiB 2.83 KiB
error-summary.mjs 7.89 KiB 3.46 KiB
exit-this-page.mjs 17.1 KiB 9.26 KiB
header.mjs 4.46 KiB 2.6 KiB
notification-banner.mjs 6.26 KiB 2.62 KiB
password-input.mjs 15.15 KiB 7.25 KiB
radios.mjs 4.83 KiB 2.38 KiB
skip-link.mjs 4.39 KiB 2.18 KiB
tabs.mjs 10.13 KiB 6.11 KiB

View stats and visualisations on the review app


Action run for 6f10857

@querkmachine querkmachine changed the title [WIP] Update review app examples for external audit Update review app examples for external audit Jul 23, 2024
@querkmachine querkmachine requested a review from a team July 23, 2024 11:07
@querkmachine querkmachine mentioned this pull request Jul 23, 2024
18 tasks
@querkmachine querkmachine marked this pull request as ready for review July 23, 2024 12:23
@querkmachine querkmachine changed the title Update review app examples for external audit Update review app examples Jul 23, 2024
@querkmachine querkmachine force-pushed the add-review-app-examples branch from 3f3c7ef to 6f10857 Compare July 23, 2024 13:03
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-5088 July 23, 2024 13:03 Inactive
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One pithy comment about the comment. Everything else looks grand. I don't see why we can't merge this.

@querkmachine querkmachine merged commit 5bafe64 into main Jul 26, 2024
52 checks passed
@querkmachine querkmachine deleted the add-review-app-examples branch July 26, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new review app example pages in preparation for external audit
3 participants