New publications page toggle #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work is part of upgrading Mainstream Publisher to use the GOV.UK Design System, in place of the current, and outdated, bootstrap UI. This commit renames the `RootController` class to `LegacyRootController`. The next commit will create a new `RootController` class, with a feature toggle to control which is used. Some tests, which were asserting that the "index" action of the "root" controller was being redirected to, have been updated to instead assert that the `root_path` has been redirected to so that they are agnostic to this change. Renaming the legacy controller now (rather than creating a new controller for the new version) will make cleanup at the end easier when we remove the feature toggle and all legacy root code.
Create a new `RootController` class and conditionally route to it or the `LegacyRootController` based on whether the new "design_system_publications_filter" feature is enabled (it defaults to disabled). In this commit `RootController` is an exact duplicate of `LegacyRootController`, but future commits will update this so that it uses the new, GOV.UK Design System-based, design.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The `LegacyRootController` is a duplicate of the `RootController` and so all of the same brakeman results (and therefore ignores) apply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a feature toggle for routing the root path
Route requests to the root path (which is where the list of filtered publications is shown), based on the status of the "design_system_publications_filter" feature toggle to either
LegacyRootControllerorRootController. For now, these controllers are functionally identical, but theRootControllerwill be changed in upcoming PR(s) to use new designs that take advantage of the GOV.UK Design System.Trello card