Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New publications page toggle #2240

Merged
merged 3 commits into from
Jul 12, 2024
Merged

New publications page toggle #2240

merged 3 commits into from
Jul 12, 2024

Commits on Jul 11, 2024

  1. Rename RootController to LegacyRootController 

    This work is part of upgrading Mainstream Publisher to use the GOV.UK Design System, in place of the current, and outdated, bootstrap UI.

This commit renames the `RootController` class to `LegacyRootController`. The next commit will create a new `RootController` class, with a feature toggle to control which is used.

Some tests, which were asserting that the "index" action of the "root" controller was being redirected to, have been updated to instead assert that the `root_path` has been redirected to so that they are agnostic to this change.

Renaming the legacy controller now (rather than creating a new controller for the new version) will make cleanup at the end easier when we remove the feature toggle and all legacy root code.
    @mtaylorgds
    mtaylorgds committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c3535d1 View commit details
    Browse the repository at this point in the history

  2. Add a new RootController 

    Create a new `RootController` class and conditionally route to it or the
 `LegacyRootController` based on whether the new
 "design_system_publications_filter" feature is enabled (it defaults to
 disabled).

In this commit `RootController` is an exact duplicate of
 `LegacyRootController`, but future commits will update this so that it
 uses the new, GOV.UK Design System-based, design.
    @mtaylorgds
    mtaylorgds committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1bf87a4 View commit details
    Browse the repository at this point in the history

  3. Update brakeman ignore file 

    The `LegacyRootController` is a duplicate of the `RootController` and so
 all of the same brakeman results (and therefore ignores) apply.
    @mtaylorgds
    mtaylorgds committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    147e896 View commit details
    Browse the repository at this point in the history