Restore specialist document types in allowed list #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've recently removed the specialist document types from the allowed list, in an effort to relax the schema, so that it only checks that the document type is a string. There are places that use this list, and it should include all the allowed types. We can keep the rest of our changes towards relaxing the schema.
ChrisBAshton
approved these changes
Oct 16, 2024
kevindew
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Thanks this will fix our issue on GOV.UK Chat and I understand it'll stop the dev docs from breaking. Though expect you should have a Publishing Platform review too.
Would suggest you don't need the custom overrides like:
publishing-api/lib/schema_generator/format.rb
Lines 175 to 177 in 4c12369
This was referenced Oct 16, 2024
Fair shout 🫡. Changes in #2918. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently removed the specialist document types from the allowed list, in an effort to relax the schema, so that it only checks that the document type is a string.
There are places that use this list, and it should include all the allowed types. We can keep the rest of our changes towards relaxing the schema.
Original PR
Original Trello card