Remove custom logic for specialist document type #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we need to use the allowed list anyway, we can remove the if-else check and allow the generator to populate the doc type list with all the allowed types, which makes it a bit more restrictive than just "string".
lauraghiorghisor-tw
force-pushed
the
make-specialist-document-schema-more-restrictive-on-doc-type
branch
from
aaff4b0 to
663c5b3
Compare
ChrisBAshton
approved these changes
Oct 16, 2024
lauraghiorghisor-tw
deleted the
make-specialist-document-schema-more-restrictive-on-doc-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we need to use the allowed list anyway, we can remove the if-else check and allow the generator to populate the doc type list with all the allowed types, which makes it a bit more restrictive than just "string".
Related PR
Original trello card