Add js-cross devShell #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merely injects `--host` and `--target` flags into the recommended `configure` arguments.
As suggested by @doyougnu on alpmestan#169.
Closed
chreekat
commented
Jul 6, 2023
| cross compiler smoke test: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: |
There was a problem hiding this comment.
If there's some way to not duplicate the setup steps between jobs, I'm all ears.
|
Hopefully I fixed the job failure :) |
|
Sigh... once more |
|
(But which is it? I've been calling it the "wasm backend", not the "wasi backend") |
MangoIV
reviewed
Jul 6, 2023
Neatly sidestepping the question of *which* example to provide.
Sorry, yes, that was a poor choice of name on my part. I think "wasm backend" is indeed more accurate. Feel free to rename it. |
|
@bgamari hehe ok. But not in this PR I think, since it doesn't include any changes to the wasm/wasi side. I think this particular PR is good to go now. |
|
Hello, is this PR stuck on something? What can be done to move this forward? |
MangoIV
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #169.
I tried to add some CI, but I haven't messed with GitHub Actions much yet. Let's see how it goes.