This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
Update EV localityName lint #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since EV ver 1.6.4 and ballot 191, localityName is optional if stateOrProvinceName is present. Closes amazon-archives#65
| unless subjattrs.include? 'L' | ||
| messages << 'E: EV certificates must include localityName in subject' | ||
| if !(subjattrs.include? 'L') && !(subjattrs.include? 'ST') | ||
| messages << 'E: EV certificates must include either localityName or stateOrProvinceName' |
There was a problem hiding this comment.
For consistency, I think that error message should retain the " in subject" suffix.
|
x509lint merged an equivalent PR yesterday (kroeckx/x509lint#32), and ZLint already had the now-correct behaviour. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since EV ver 1.6.4 and ballot 191, localityName is optional if stateOrProvinceName is present.
Closes: #65