Skip to content
This repository has been archived by the owner on Jun 19, 2020. It is now read-only.

Update EV localityName lint #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update EV localityName lint #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/certlint/cablint.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,8 @@ def self.lint(der)
unless subjattrs.include? 'serialNumber'
messages << 'E: EV certificates must include serialNumber in subject'
end
unless subjattrs.include? 'L'
messages << 'E: EV certificates must include localityName in subject'
if !(subjattrs.include? 'L') && !(subjattrs.include? 'ST')
messages << 'E: EV certificates must include either localityName or stateOrProvinceName'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, I think that error message should retain the " in subject" suffix.

end
unless subjattrs.include? 'C'
messages << 'E: EV certificates must include countryName in subject'
Expand Down