Code Coverage

Fixed bug in text lists #2010

Triggered via push December 6, 2023 22:09

zslayton

pushed 5616d1d

so-so-broken

Status Success

Total duration 2m 40s

Artifacts –

coverage.yml

on: push

Matrix: Build and Test

Annotations

18 errors and 5 warnings

methods called `as_*` usually take `self` by reference or `self` by mutable reference: src/lazy/encoder/write_as_ion.rs#L291

error: methods called `as_*` usually take `self` by reference or `self` by mutable reference --> src/lazy/encoder/write_as_ion.rs:291:16 | 291 | fn as_sexp(self) -> SExpTypeHint<Self, T>; | ^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `-D clippy::wrong-self-convention` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::wrong_self_convention)]`

deref on an immutable reference: src/lazy/encoder/binary/mod.rs#L305

error: deref on an immutable reference --> src/lazy/encoder/binary/mod.rs:305:13 | 305 | &*self.values_writer.allocator, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.values_writer.allocator` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

deref on an immutable reference: src/lazy/encoder/binary/mod.rs#L248

error: deref on an immutable reference --> src/lazy/encoder/binary/mod.rs:248:13 | 248 | &*self.values_writer.allocator, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.values_writer.allocator` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

this expression creates a reference which is immediately dereferenced by the compiler: src/lazy/encoder/binary/mod.rs#L186

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/lazy/encoder/binary/mod.rs:186:51 | 186 | BinaryAnnotatableValueWriter_1_0::new(&self.allocator, &mut self.buffer); | ^^^^^^^^^^^^^^^ help: change this to: `self.allocator` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: src/lazy/encoder/binary/value_writer.rs#L556

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/lazy/encoder/binary/value_writer.rs:556:52 | 556 | BinaryValueWriter_1_0::new(self.allocator, &mut self.buffer) | ^^^^^^^^^^^^^^^^ help: change this to: `self.buffer` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: src/lazy/encoder/binary/value_writer.rs#L422

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/lazy/encoder/binary/value_writer.rs:422:71 | 422 | let mut encoded_annotations_sequence_length = BumpVec::new_in(&self.allocator); | ^^^^^^^^^^^^^^^ help: change this to: `self.allocator` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: src/lazy/encoder/binary/value_writer.rs#L419

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/lazy/encoder/binary/value_writer.rs:419:64 | 419 | let mut encoded_annotations_sequence = BumpVec::new_in(&self.allocator); | ^^^^^^^^^^^^^^^ help: change this to: `self.allocator` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

deref on an immutable reference: src/lazy/encoder/binary/value_writer.rs#L408

error: deref on an immutable reference --> src/lazy/encoder/binary/value_writer.rs:408:25 | 408 | let allocator = &*self.allocator; | ^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.allocator` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref = note: `-D clippy::borrow-deref-ref` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::borrow_deref_ref)]`

this expression creates a reference which is immediately dereferenced by the compiler: src/lazy/encoder/binary/value_writer.rs#L266

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/lazy/encoder/binary/value_writer.rs:266:13 | 266 | &self.allocator, | ^^^^^^^^^^^^^^^ help: change this to: `self.allocator` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

methods called `as_*` usually take `self` by reference or `self` by mutable reference: src/lazy/encoder/write_as_ion.rs#L291