Skip to content
Code Coverage

Fixed bug in text lists #2010

Sign in to view logs

Fixed bug in text lists

Fixed bug in text lists #2010

GitHub Actions / clippy failed Dec 6, 2023 in 0s

clippy

18 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 18
Warning 0
Note 0
Help 0

Versions

  • rustc 1.74.0 (79e9716c9 2023-11-13)
  • cargo 1.74.0 (ecb9851af 2023-10-18)
  • clippy 0.1.74 (79e9716 2023-11-13)

Annotations

Check failure on line 291 in src/lazy/encoder/write_as_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

methods called `as_*` usually take `self` by reference or `self` by mutable reference 

error: methods called `as_*` usually take `self` by reference or `self` by mutable reference
   --> src/lazy/encoder/write_as_ion.rs:291:16
    |
291 |     fn as_sexp(self) -> SExpTypeHint<Self, T>;
    |                ^^^^
    |
    = help: consider choosing a less ambiguous name
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
    = note: `-D clippy::wrong-self-convention` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::wrong_self_convention)]`

Check failure on line 305 in src/lazy/encoder/binary/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref on an immutable reference 

error: deref on an immutable reference
   --> src/lazy/encoder/binary/mod.rs:305:13
    |
305 |             &*self.values_writer.allocator,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.values_writer.allocator`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

Check failure on line 248 in src/lazy/encoder/binary/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref on an immutable reference 

error: deref on an immutable reference
   --> src/lazy/encoder/binary/mod.rs:248:13
    |
248 |             &*self.values_writer.allocator,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.values_writer.allocator`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

Check failure on line 186 in src/lazy/encoder/binary/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/lazy/encoder/binary/mod.rs:186:51
    |
186 |             BinaryAnnotatableValueWriter_1_0::new(&self.allocator, &mut self.buffer);
    |                                                   ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 556 in src/lazy/encoder/binary/value_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/lazy/encoder/binary/value_writer.rs:556:52
    |
556 |         BinaryValueWriter_1_0::new(self.allocator, &mut self.buffer)
    |                                                    ^^^^^^^^^^^^^^^^ help: change this to: `self.buffer`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 422 in src/lazy/encoder/binary/value_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/lazy/encoder/binary/value_writer.rs:422:71
    |
422 |         let mut encoded_annotations_sequence_length = BumpVec::new_in(&self.allocator);
    |                                                                       ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 419 in src/lazy/encoder/binary/value_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/lazy/encoder/binary/value_writer.rs:419:64
    |
419 |         let mut encoded_annotations_sequence = BumpVec::new_in(&self.allocator);
    |                                                                ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 408 in src/lazy/encoder/binary/value_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref on an immutable reference 

error: deref on an immutable reference
   --> src/lazy/encoder/binary/value_writer.rs:408:25
    |
408 |         let allocator = &*self.allocator;
    |                         ^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.allocator`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
    = note: `-D clippy::borrow-deref-ref` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::borrow_deref_ref)]`

Check failure on line 266 in src/lazy/encoder/binary/value_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/lazy/encoder/binary/value_writer.rs:266:13
    |
266 |             &self.allocator,
    |             ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `-D clippy::needless-borrow` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

Check failure on line 291 in src/lazy/encoder/write_as_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

methods called `as_*` usually take `self` by reference or `self` by mutable reference 

error: methods called `as_*` usually take `self` by reference or `self` by mutable reference
   --> src/lazy/encoder/write_as_ion.rs:291:16
    |
291 |     fn as_sexp(self) -> SExpTypeHint<Self, T>;
    |                ^^^^
    |
    = help: consider choosing a less ambiguous name
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
    = note: `-D clippy::wrong-self-convention` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::wrong_self_convention)]`

Check failure on line 305 in src/lazy/encoder/binary/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref on an immutable reference 

error: deref on an immutable reference
   --> src/lazy/encoder/binary/mod.rs:305:13
    |
305 |             &*self.values_writer.allocator,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.values_writer.allocator`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

Check failure on line 248 in src/lazy/encoder/binary/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref on an immutable reference 

error: deref on an immutable reference
   --> src/lazy/encoder/binary/mod.rs:248:13
    |
248 |             &*self.values_writer.allocator,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.values_writer.allocator`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

Check failure on line 186 in src/lazy/encoder/binary/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/lazy/encoder/binary/mod.rs:186:51
    |
186 |             BinaryAnnotatableValueWriter_1_0::new(&self.allocator, &mut self.buffer);
    |                                                   ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 556 in src/lazy/encoder/binary/value_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/lazy/encoder/binary/value_writer.rs:556:52
    |
556 |         BinaryValueWriter_1_0::new(self.allocator, &mut self.buffer)
    |                                                    ^^^^^^^^^^^^^^^^ help: change this to: `self.buffer`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 422 in src/lazy/encoder/binary/value_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/lazy/encoder/binary/value_writer.rs:422:71
    |
422 |         let mut encoded_annotations_sequence_length = BumpVec::new_in(&self.allocator);
    |                                                                       ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 419 in src/lazy/encoder/binary/value_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/lazy/encoder/binary/value_writer.rs:419:64
    |
419 |         let mut encoded_annotations_sequence = BumpVec::new_in(&self.allocator);
    |                                                                ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 408 in src/lazy/encoder/binary/value_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref on an immutable reference 

error: deref on an immutable reference
   --> src/lazy/encoder/binary/value_writer.rs:408:25
    |
408 |         let allocator = &*self.allocator;
    |                         ^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.allocator`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
    = note: `-D clippy::borrow-deref-ref` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::borrow_deref_ref)]`

Check failure on line 266 in src/lazy/encoder/binary/value_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/lazy/encoder/binary/value_writer.rs:266:13
    |
266 |             &self.allocator,
    |             ^^^^^^^^^^^^^^^ help: change this to: `self.allocator`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `-D clippy::needless-borrow` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
View more details on GitHub Actions