Updates codecov.io GH action #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
=======================================
Coverage 77.26% 77.26%
=======================================
Files 135 135
Lines 33415 33415
Branches 33415 33415
=======================================
Hits 25819 25819
Misses 5654 5654
Partials 1942 1942 ☔ View full report in Codecov by Sentry. |
zslayton
commented
Nov 8, 2024
Comment on lines
-21
to
+22
| - name: Rust Toolchain | ||
| uses: actions-rs/toolchain@v1 | ||
| - name: Install Rust toolchain | ||
| uses: dtolnay/rust-toolchain@stable |
There was a problem hiding this comment.
🗺️ The GH Actions owned by the actions-rs organization are now archived and unmaintained. dtolnay/rust-toolchain is its successor.
Comment on lines
-42
to
-43
| env: | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
🗺️ Removing this as #852 added with: token on line 35 below (hidden by default in this diff).
| override: true | ||
| # Wrapper for running coverage with -C instrument-coverage | ||
| - name: Cargo Install Coverage Wrapper | ||
| uses: actions-rs/cargo@v1 |
There was a problem hiding this comment.
🗺️ The actions-rs/cargo action was a pretty thin layer around simple cargo [subcommand] operations. I'm not sure how much value it was really adding.
popematt
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #851.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.