Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates codecov.io GH action #853

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Updates codecov.io GH action #853

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bce748
experiment
zslayton Nov 8, 2024
70dbbce
cleanup
zslayton Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 9 additions & 21 deletions .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,33 +14,21 @@ jobs:
os: [ ubuntu-latest ]

steps:
- name: Git Checkout
uses: actions/checkout@v3
- name: Git checkout
uses: actions/checkout@v4
with:
submodules: recursive
- name: Rust Toolchain
uses: actions-rs/toolchain@v1
- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@stable
Comment on lines -21 to +22
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗺️ The GH Actions owned by the actions-rs organization are now archived and unmaintained. dtolnay/rust-toolchain is its successor.

with:
profile: minimal
toolchain: stable
# We need this component to generate source coverage in stable
components: llvm-tools-preview
override: true
# Wrapper for running coverage with -C instrument-coverage
- name: Cargo Install Coverage Wrapper
uses: actions-rs/cargo@v1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗺️ The actions-rs/cargo action was a pretty thin layer around simple cargo [subcommand] operations. I'm not sure how much value it was really adding.

with:
command: install
args: cargo-llvm-cov
- name: Cargo Test w/ Coverage
uses: actions-rs/cargo@v1
with:
command: llvm-cov
args: --verbose --workspace --all-features --no-fail-fast --codecov --output-path codecov.json
- name: Codecov Upload
- name: Install `cargo-llvm-cov`
run: cargo install cargo-llvm-cov
- name: Cargo test w/code coverage
run: cargo llvm-cov --verbose --workspace --all-features --no-fail-fast --codecov --output-path codecov.json
- name: Codecov upload
uses: codecov/codecov-action@v4
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
Comment on lines -42 to -43
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗺️ Removing this as #852 added with: token on line 35 below (hidden by default in this diff).

https://github.com/amazon-ion/ion-rust/pull/853/files#diff-a2115d277b5ca5a2f09a999e53440839cf332b94da177f3d1766334555b0f7c6L44-L47

with:
files: codecov.json
fail_ci_if_error: true
Expand Down
Loading