fix: use the id property instead of name for read ilm tier #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed due to a foundational change in Docker Compose CLI.
This is needed due to a change in Docker Compose CLI.
felladrin
approved these changes
Aug 12, 2024
kireque
pushed a commit
to kireque/home-ops
that referenced
this pull request
Aug 13, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [minio](https://registry.terraform.io/providers/aminueza/minio) ([source](https://togithub.com/aminueza/terraform-provider-minio)) | required_provider | patch | `2.4.2` -> `2.4.3` | --- ### Release Notes <details> <summary>aminueza/terraform-provider-minio (minio)</summary> ### [`v2.4.3`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v2.4.3) [Compare Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v2.4.2...v2.4.3) #### What's Changed - fix: use the id property instead of name for read ilm tier by [@​s-vitaliy](https://togithub.com/s-vitaliy) in [aminueza/terraform-provider-minio#579 **Full Changelog**: aminueza/terraform-provider-minio@v2.4.2...v2.4.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNS4yIiwidXBkYXRlZEluVmVyIjoiMzguMjUuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvdGVycmFmb3JtIiwidHlwZS9wYXRjaCJdfQ==--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When terraform performs an import of a resource only the
idproperty is available in the provider context. But theminio_ilm_tierresource uses thenameproperty to get the tier from MinIO api (which is empty) and import of the ilm tier fails.This PR implements the following changes:
idcontext property instead ofnamefor reading theminio_ilm_tierresourceReference
Resolves #578