Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use the id property instead of name for read ilm tier #579

Merged
merged 3 commits into from
Aug 12, 2024
Merged

fix: use the id property instead of name for read ilm tier #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec6b606
fix: use the id property instead of name for read ilm tier
s-vitaliy Aug 12, 2024
9e326ff
Replace `docker-compose` with `docker compose`
felladrin Aug 12, 2024
cde4e12
Replace `docker-compose` with `docker compose`
felladrin Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ jobs:
with:
version: "2023.1.6"
install-go: false
- name: Build the docker-compose stack
run: docker-compose up -d minio secondminio thirdminio fourthminio
- name: Build the Docker Compose stack
run: docker compose up -d minio secondminio thirdminio fourthminio
- uses: hashicorp/setup-terraform@v2
with:
terraform_version: 1.5.7
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ variable "minio_password" {
For testing locally, run the docker compose to spin up a minio server:

```sh
docker-compose up
docker compose up
```

Access `http://localhost:8000` on your browser, apply your terraform templates and watch them going live.
Expand Down
2 changes: 1 addition & 1 deletion minio/resource_minio_ilm_tier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ func minioCreateILMTier(ctx context.Context, d *schema.ResourceData, meta interf

func minioReadILMTier(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
c := meta.(*S3MinioClient).S3Admin
name := d.Get("name").(string)
name := d.Id()
tier, err := getTier(c, ctx, name)
if err != nil {
return NewResourceError("reading remote tier failed", name, err)
Expand Down
Loading