feat: add client upload time #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mercy811
force-pushed
the
feat-add-client-upload-time
branch
from
22127d6 to
2c397cf
Compare
liuyang1520
approved these changes
Oct 18, 2023
falconandy
suggested changes
Oct 19, 2023
falconandy
approved these changes
Oct 25, 2023
This reverts commit 2be2931.
justin-fiedler
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Thanks @Mercy811. Changes look great. See suggested nit fixes.
Co-authored-by: Justin Fiedler <[email protected]>
Co-authored-by: Justin Fiedler <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
# [1.1.0](v1.0.0...v1.1.0) (2023-10-30) ### Features * add client upload time ([#94](#94)) ([a0d59f1](a0d59f1))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://amplitude.atlassian.net/browse/AMP-87208
Adding
client_upload_timeso that when client-side clock is drifted, backend can correct itChecklist