-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix test.yml #475
ci: fix test.yml #475
Conversation
Package.resolved
Outdated
@@ -0,0 +1,16 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no. I removed it at c0cd582
-sdk appletvsimulator \ | ||
-destination 'platform=tvOS Simulator,name=Apple TV' \ | ||
test | ||
# - name: tvOS Tests @TODO Fix flaky tvOS tests and re-enable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious what's the error earlier for tvOS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the link of failed test mentioned in the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b10b42a
to
c0cd582
Compare
🎉 This PR is included in version 8.18.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Summary
Fix outdated test setups.
My recent PR failed on test: https://github.com/amplitude/Amplitude-iOS/actions/runs/7659377311/job/20874360703?pr=473
Comment out flaky tvOS tests as what we did for macOS tests. They are not stable. See this PR which triggers tvOS tests twice, one passed but one failed.
Checklist