Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix test.yml #475

Merged
merged 1 commit into from
Jan 26, 2024
Merged

ci: fix test.yml #475

merged 1 commit into from
Jan 26, 2024

Conversation

Mercy811
Copy link
Contributor

@Mercy811 Mercy811 commented Jan 25, 2024

Summary

Fix outdated test setups.
My recent PR failed on test: https://github.com/amplitude/Amplitude-iOS/actions/runs/7659377311/job/20874360703?pr=473
image
image

Comment out flaky tvOS tests as what we did for macOS tests. They are not stable. See this PR which triggers tvOS tests twice, one passed but one failed.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

Package.resolved Outdated
@@ -0,0 +1,16 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no. I removed it at c0cd582

-sdk appletvsimulator \
-destination 'platform=tvOS Simulator,name=Apple TV' \
test
# - name: tvOS Tests @TODO Fix flaky tvOS tests and re-enable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious what's the error earlier for tvOS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the link of failed test mentioned in the description.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mercy811 Mercy811 marked this pull request as ready for review January 26, 2024 01:01
@Mercy811 Mercy811 merged commit 7ed1b8c into main Jan 26, 2024
3 checks passed
@Mercy811 Mercy811 deleted the ci-fix-test-yml branch January 26, 2024 01:01
Copy link

github-actions bot commented Feb 8, 2024

🎉 This PR is included in version 8.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants