ci: fix test.yml #475
Merged
ci: fix test.yml #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-fiedler
approved these changes
Jan 25, 2024
Package.resolved
Outdated
| @@ -0,0 +1,16 @@ | |||
| { | |||
There was a problem hiding this comment.
Do we need this file?
There was a problem hiding this comment.
Oh no. I removed it at c0cd582
| -sdk appletvsimulator \ | ||
| -destination 'platform=tvOS Simulator,name=Apple TV' \ | ||
| test | ||
| # - name: tvOS Tests @TODO Fix flaky tvOS tests and re-enable |
There was a problem hiding this comment.
Curious what's the error earlier for tvOS?
There was a problem hiding this comment.
Here is the link of failed test mentioned in the description.
There was a problem hiding this comment.
Mercy811
force-pushed
the
ci-fix-test-yml
branch
from
b10b42a
to
c0cd582
Compare
|
🎉 This PR is included in version 8.18.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix outdated test setups.
My recent PR failed on test: https://github.com/amplitude/Amplitude-iOS/actions/runs/7659377311/job/20874360703?pr=473
Comment out flaky tvOS tests as what we did for macOS tests. They are not stable. See this PR which triggers tvOS tests twice, one passed but one failed.
Checklist