Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix test.yml #475

Merged
merged 1 commit into from
Jan 26, 2024
+11 −11
Merged

ci: fix test.yml #475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: macos-12
strategy:
matrix:
ruby-version: ["2.7.x"]
ruby-version: ["2.7"]
steps:
- name: Check out Git repository
uses: actions/checkout@v2
Expand All @@ -21,13 +21,13 @@ jobs:
run: carthage bootstrap --use-xcframeworks

- name: Setup Ruby
uses: actions/setup-ruby@v1
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}

- name: Install Cocoapods
run: |
gem install bundler
gem install bundler -v 2.4.22
bundle config path vendor/bundle
bundle install
pod install
Expand All @@ -52,11 +52,11 @@ jobs:
# -destination 'platform=macosx' \
# test

- name: tvOS Tests
run: |
xcodebuild \
-workspace Amplitude.xcworkspace \
-scheme Amplitude_tvOS \
-sdk appletvsimulator \
-destination 'platform=tvOS Simulator,name=Apple TV' \
test
# - name: tvOS Tests @TODO Fix flaky tvOS tests and re-enable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious what's the error earlier for tvOS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the link of failed test mentioned in the description.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/questions/52455652/xcode-10-seems-to-break-com-apple-commcenter-coretelephony-xpc This might help

# run: |
# xcodebuild \
# -workspace Amplitude.xcworkspace \
# -scheme Amplitude_tvOS \
# -sdk appletvsimulator \
# -destination 'platform=tvOS Simulator,name=Apple TV' \
# test
Loading