Update cn0363 spi engine #1183
Merged
Update cn0363 spi engine #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIoandan
requested review from
acostina,
AndreiGrozav and
PopPaul2021
as code owners
gastmaier
reviewed
Sep 27, 2023
| set_property PACKAGE_PIN Y11 [get_ports gain0_o] | ||
| set_property IOSTANDARD LVCMOS33 [get_ports gain0_o] | ||
| set_property PACKAGE_PIN AA11 [get_ports gain1_o] | ||
| set_property PACKAGE_PIN Y11 [get_ports gain0_o] ; ## PMOD [2] PMOD JA1 IO_L10P_T1 |
There was a problem hiding this comment.
How about also reordering those for clarity? package_pin first, then iostandard?
IuliaCMoldovan
requested changes
Sep 28, 2023
PIoandan
force-pushed
the
update_cn0363_spi_engine
branch
from
f30635e
to
98bbd55
Compare
I replaced the SPI Engine connections in the cn0363_bd.tcl with the spi_engine_create procedure found in the spi_engine.tcl script. Through these changes, a more generic instantiation for the spi_engine can be achieved. I updated the system_constr.xdc file and created the cn0363_pmod.txt file. Signed-off-by: Ioan-daniel Pop <[email protected]>
PIoandan
force-pushed
the
update_cn0363_spi_engine
branch
from
98bbd55
to
4e13af5
Compare
I modified the Readme.md file. Signed-off-by: Ioan-daniel Pop <[email protected]>
PopPaul2021
requested changes
Oct 2, 2023
projects/cn0363/common/cn0363_bd.tcl
Outdated
|
|
||
| ad_mem_hp2_interconnect $sys_cpu_clk sys_ps7/S_AXI_HP2 | ||
| ad_mem_hp2_interconnect $sys_cpu_clk axi_dma/m_dest_axi | ||
| ad_mem_hp2_interconnect $sys_cpu_clk axi_dma/m_dest_axi |
There was a problem hiding this comment.
Please add an empty line.
| set_property -dict {PACKAGE_PIN AB11 IOSTANDARD LVCMOS33} [get_ports {spi_cs[0]}] ; ## PMOD [1] PMOD JA7 IO_L8N_T1 | ||
| set_property -dict {PACKAGE_PIN AB10 IOSTANDARD LVCMOS33 PULLUP true} [get_ports spi_sdo] ; ## PMOD [3] PMOD JA8 IO_L9P_T1_DQS | ||
| set_property -dict {PACKAGE_PIN AB9 IOSTANDARD LVCMOS33 PULLUP true} [get_ports spi_sdi] ; ## PMOD [5] PMOD JA9 IO_L9N_T1_DQS | ||
| set_property -dict {PACKAGE_PIN AA8 IOSTANDARD LVCMOS33} [get_ports spi_sclk] ; ## PMOD [7] PMOD JA10 IO_L11N_T1_SRCC |
There was a problem hiding this comment.
Please add an empty line.
Added an empty line at the end of the cn0363_bd.tcl and system_constr.xdc files. Signed-off-by: Ioan-daniel Pop <[email protected]>
I edited the cn0363_pmod.txt file. Signed-off-by: Ioan-daniel Pop <[email protected]>
gastmaier
previously approved these changes
Oct 10, 2023
PopPaul2021
requested changes
Oct 20, 2023
|
|
||
| # cn0363 | ||
|
|
||
| PMOD [2] PMOD JA1 GAIN0 gain0_o LVCMOS33 #N/A |
There was a problem hiding this comment.
The ports and pins should be updated similarly to the pulsar project.
| set_property PACKAGE_PIN AA8 [get_ports spi_sclk] | ||
| set_property IOSTANDARD LVCMOS33 [get_ports spi_sclk] | ||
|
|
||
| set_property -dict {PACKAGE_PIN Y11 IOSTANDARD LVCMOS33} [get_ports gain0_o] ; ## PMOD [2] PMOD JA1 IO_L10P_T1 |
There was a problem hiding this comment.
The comments should be revised because they refer to ports that are routed to the FMC connector.
Updated the pin and port name in cn0363_pmod.txt and system_constr.xdc files. Signed-off-by: Ioan-daniel Pop <[email protected]>
PopPaul2021
approved these changes
Oct 23, 2023
acostina
approved these changes
Oct 25, 2023
IuliaCMoldovan
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I replaced the SPI Engine connections in the cn0363_bd.tcl with the
spi_engine_create procedure found in the spi_engine.tcl script. Through
these changes, a more generic instantiation for the spi_engine can be
achieved. I updated the system_constr.xdc and makefile files and created the cn0363_pmod.txt file.
The linux part works fine.
PR Type
PR Checklist