(CI for #1201) TCL: ad_hpmx_interconnect #1416
Closed
+72
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastmaier
requested review from
acostina,
AndreiGrozav,
PopPaul2021 and
sarpadi
as code owners
|
This should be run on all projects to ensure no project is broken by it |
|
RetriggerCI |
AndreiGrozav
previously approved these changes
Sep 3, 2024
Rework ad_cpu_interconnect to support other master axi interfaces. Add create_bd_addr_seg logs. Signed-off-by: Liam Beguin <[email protected]>
The variable sys_zynq is a global var. Line breaks matter in TCL. Signed-off-by: Jorge Marques <[email protected]>
With the rework of ad_cpu_interconnect to allow other PS AXI manager ports, the interconnect IP name now reflects the AXI manager port name. Rename axi_cpu_interconnect in projects to match the PS AXI manager port name. Signed-off-by: Jorge Marques <[email protected]>
gastmaier
force-pushed
the
ad_hpmx_interconnect
branch
from
355c429
to
3120cc5
Compare
|
Merging original PR #1201 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Trigger CI for #1201
Added fixes to the o.g. PR and updated affected projects (those touching "ad_cpu_interconnect" IP core directly)
Some custom projects might rely on other PS AXI master interfaces, rework ad_cpu_interconnect to allow users to specify other interfaces.
For now, I was only able to test this on a zynqmp project, and don't have the full list of interfaces for other platforms, but I'm happy to update the PR.
This PR should run on all projects. Already rebased on main.
PR Type
PR Checklist