pulsar_adc: add split transfer functionality #1474
Draft
+57
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LBFFilho
force-pushed
the
pulsar_split_transfers
branch
from
c08ce80
to
92a20ee
Compare
|
Looks good. Should work as long as the software resets the FIFO properly. I would try using only one build parameter. Either use a fixed width value or use only the SPLIT_SIZE parameter. if SPLIT_SIZE = 0 (default) then the feature is not used at all, if SPLIT_SIZE != 0 then use the value as width or something similar. |
add a parameter, SPLIT_TRANSFER_SIZE, to enable and control split transfers. If SPLIT_TRANSFER_SIZE is set to 0 (default), the project behaves as usual (no split transfers). Otherwise, an asymetric fifo is used to stitch together 2 transfers before sending them to the DMA, SPLIT_TRANSFER_SIZE being used to indicate the size of each transfer in the split. Signed-off-by: Laez Barbosa <[email protected]>
LBFFilho
force-pushed
the
pulsar_split_transfers
branch
from
92a20ee
to
a99fac3
Compare
Signed-off-by: Laez Barbosa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a parameter, SPLIT_TRANSFER SIZE to enable split transfers. If SPLIT_TRANSFER is set to 0, split transfers are disabled (previous behavior). If set to any other positive value =an asymetric fifo is used to stitch together 2 transfers before sending them to the DMA. In this case SPLIT_TRANSFER is used to indicate the size of each transfer in the split.
PR Type
PR Checklist