Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ad9081_fmca_ebz: common: versal_transceiver: Force progdiv_clk to float #1505

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ad9081_fmca_ebz: common: versal_transceiver: Force progdiv_clk to float #1505

wants to merge 1 commit into from

Conversation

bluncan
Copy link
Contributor

@bluncan bluncan commented Nov 5, 2024 •
edited
Loading

PR Description

The [rx/tx]_progdiv_clock was truncated if the lane rate was an integer. So for a lane rate of '10', the ref clock calculated was 151.000 instead of 151.515.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@bluncan
ad9081_fmca_ebz: common: versal_transceiver: Force progdiv_clk to float
337a379 
The [rx/tx]_progdiv_clock was truncated if the lane rate was an integer.
So for a lane rate of '10', the ref clock calculated was 151.000
instead of 151.515.

Signed-off-by: Bogdan Luncan <[email protected]>
@bluncan bluncan force-pushed the versal_fix_progdiv_clk_for_integer_lanerate branch from 3da0453 to 337a379 Compare November 5, 2024 05:48
gastmaier
gastmaier approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the behavior with

set var2 [format %.3f [expr 2 * 1000.0 / 3]]
666.667
set var2 [format %.3f [expr 2 * 1000 / 3]]
666.000

at vivado tcl console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilipG24 FilipG24 FilipG24 approved these changes

@gastmaier gastmaier gastmaier approved these changes

@IuliaCMoldovan IuliaCMoldovan Awaiting requested review from IuliaCMoldovan IuliaCMoldovan is a code owner

@AndrDragomir AndrDragomir Awaiting requested review from AndrDragomir AndrDragomir is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluncan @gastmaier @FilipG24