Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit_level_tb: Revert SV support #1509

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IstvanZsSzekely
Copy link
Contributor

PR Description

Added SystemVerilog support breaks some of the current unit level testbenches.
Removing support for SystemVerilog, until incompatibilities between Verilog and SystemVerilog are understood and fixed.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

- Added SystemVerilog support breaks some of the current unit level testbenches

Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
@gastmaier
Copy link
Contributor

do you have a list of the broken ones?

@IstvanZsSzekely
Copy link
Contributor Author

Yes, here are the testbenches that are failing in addition to the ones that were already failing for other reasons:
jesd204/axi_jesd204_rx_regmap_tb
jesd204/axi_jesd204_tx_regmap_tb
jesd204/soft_pcs_pattern_align_tb
util_pack/cpack_tb
util_pack/underflow_tb
util_pack/upack_tb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants