-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev dds 32b phase #864
Dev dds 32b phase #864
Conversation
1af8e2a
to
666d96f
Compare
3ed2ae0
to
93ce2c9
Compare
93ce2c9
to
b5ef692
Compare
b5ef692
to
269e45a
Compare
I have updated this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Do we want to keep the commits separate for the changes ? I understand the commit for cleanup makes sense to be separate, but the other ones if they are separate, may break compilation of the projects
Add support for DDS phase width greather than 16. The software should read the DDS phase data width register and configure the DDS init and increment registers accordingly, otherwise the obtained DDS output frequency will not be the desired one for DDS phase width different than 16. DDS_incr = (f_out * 2^(phase_width) * clkratio)/f_if
Allow upto 32 bit phase data width support.
269e45a
to
0a7aa21
Compare
Squashed functional commits. In order not to break the build. |
Add support for DDS phase width grater than 16
The software should read the DDS phase data width register and configure the DDS init and increment registers accordingly, otherwise the obtained DDS output frequency might not be the desired one, in case the DDS phase
width is different than 16(default).
Updated documentation at https://wiki.analog.com/resources/fpga/docs/dds