Make lilka::Menu component avaliable for reuse #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and3rson
requested changes
Mar 24, 2024
sdk/lib/lilka/src/lilka/ui.h
Outdated
| @@ -81,8 +81,19 @@ class Menu { | |||
| /// | |||
| /// Якщо пункт обрано (користувач натиснув кнопку "A"), повертається ``true``, інакше ``false``. Після виклику цієї функції пункт перестає бути обраним. | |||
| bool isFinished(); | |||
| /// Дозволяє змінити пункту меню | |||
There was a problem hiding this comment.
Опечатка, + краще в наказовому стилі: "Змінити пункт меню"
І ще, можна додати вже й getItem, раз вже є всі інші методи :)
and3rson
reviewed
Mar 24, 2024
sdk/lib/lilka/src/lilka/ui.h
Outdated
| /// @param color Колір пункту. За замовчуванням ``0`` (стандартний колір). | ||
| /// @param postfix Текст, який додається після заголовка пункту і вирівнюється до правого краю меню. | ||
| /// | ||
| /// Повертає значення true якщо пункт було змінено |
and3rson
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
menu->clearItems and menu->setItem implementation