Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop passing filenames to nitpick-check @ pre-commit hooks #673

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Stop passing filenames to nitpick-check @ pre-commit hooks #673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-hooks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,4 @@
description: "Only check configuration files (TOML/INI/JSON/etc.) and print the violations, according to the Nitpick style"
entry: nitpick check
language: python
pass_filenames: false
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a similar problem before, I'm not sure if changing this line will bring the issue again.

and nitpick run unconditionally checks every file always. they've sidestepped the framework and you should open an issue asking them to change to linting filenames which are passed

Loading