Made Amount more generic. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batconjurer
reviewed
Jun 30, 2023
batconjurer
reviewed
Jun 30, 2023
batconjurer
reviewed
Jun 30, 2023
| Ok(Self::zero()) | ||
| } else if 0 <= amount && amount <= MAX_MONEY { | ||
| } else if Magnitude::default() <= amount { |
There was a problem hiding this comment.
Do you think it would be worth having a trait for these magnitudes? Then we could add associated MIN_MONEY and MAX_MONEY constants.
There was a problem hiding this comment.
Maybe as a separate PR. For this PR I think it's probably be simpler to not restrict the range of Amounts allowed by the MASP crate (beyond what is already imposed by the cryptography).
…. Removed ValueSum from bool implementation.
murisi
force-pushed
the
murisi/generic-amount
branch
5 times, most recently
from
63d83f4
to
d3a4384
Compare
murisi
force-pushed
the
murisi/generic-amount
branch
from
d3a4384
to
4862ae7
Compare
2 tasks
batconjurer
reviewed
Aug 4, 2023
…ueSum. Corrected comments.
ghost
approved these changes
Aug 11, 2023
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been thinking about other approaches to allowing
u64::MAXnotes and eliminating risk of overflow problems. Here's one that came to mind. Specifically, the following changes are made:Amountgeneric over the integer type (so it can now bei64,128, or perhapsi256oru256)Checked*traits from thenum-traitslibrary (which is also used in thenamadarepo)i128to accumulatevalue_balancesThe benefits of this approach are that:
Amounttype may be easier to reuse from thenamadacrate (if we somehow useTokenChangeas the integer type) and may help to avoid having to writeMaspAmount(at https://github.com/anoma/namada/blob/ec845c28548269deb5d6ce7fef44aa1275c55d82/shared/src/ledger/masp.rs#L427 which is similar toAmount)AllowedConversioncan now be backed by ai64ori32based type, i.e. it is not forced to use a 128 bit based type because of the requirements onAmounts in other contexts. Hence space savings.MAX_MONEYvalues that are smaller than the range of the underlying integer type are not currently supported here, but it should be doable if it is desired. This is just another approach, maybe some of the ideas here could be used to extend #46 ?