-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoS redelegation #1612
Merged
Merged
PoS redelegation #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
force-pushed
the
brent/pos-redelegation
branch
6 times, most recently
from
July 2, 2023 16:32
cfe7a8a
to
8730508
Compare
brentstone
force-pushed
the
brent/pos-redelegation
branch
8 times, most recently
from
July 18, 2023 04:18
1ae11c8
to
b400eb1
Compare
brentstone
force-pushed
the
brent/pos-redelegation
branch
4 times, most recently
from
July 25, 2023 20:22
8ea76a1
to
a6a744f
Compare
brentstone
force-pushed
the
brent/pos-redelegation
branch
from
July 28, 2023 02:28
398576b
to
35a2c64
Compare
brentstone
force-pushed
the
brent/pos-redelegation
branch
from
August 9, 2023 15:56
187cb90
to
a5a8eba
Compare
2 tasks
brentstone
force-pushed
the
brent/pos-redelegation
branch
6 times, most recently
from
August 16, 2023 15:59
bc2fd9f
to
50508a5
Compare
brentstone
force-pushed
the
brent/pos-redelegation
branch
from
September 27, 2023 17:28
01746e5
to
c9c589d
Compare
pls run pos tests |
This was referenced Oct 4, 2023
Closed
Closed
brentstone
force-pushed
the
brent/pos-redelegation
branch
from
October 13, 2023 18:16
48032ac
to
68b5704
Compare
brentstone
added a commit
that referenced
this pull request
Oct 14, 2023
* brent/pos-redelegation: SQUASHED redelegation
brentstone
added a commit
that referenced
this pull request
Oct 16, 2023
* brent/pos-redelegation: SQUASHED redelegation
tzemanovic
previously approved these changes
Oct 17, 2023
tzemanovic
added a commit
that referenced
this pull request
Oct 17, 2023
* brent/pos-redelegation: remove dbg prints
tzemanovic
added a commit
that referenced
this pull request
Oct 18, 2023
* brent/pos-redelegation: PoS: comment out unused code test/e2e/slashing: fix flakiness bench/vps: credit source before bond tx make: skip pos_state_machine_test in CI
brentstone
added a commit
that referenced
this pull request
Oct 19, 2023
* brent/pos-redelegation: process_slashes: fix critical bug
brentstone
added a commit
that referenced
this pull request
Oct 19, 2023
* brent/pos-redelegation: fix bug in SMv1 test
Fraccaman
added a commit
that referenced
this pull request
Oct 23, 2023
* origin/brent/pos-redelegation: fix bug in SMv1 test process_slashes: fix critical bug PoS: comment out unused code test/e2e/slashing: fix flakiness bench/vps: credit source before bond tx make: skip pos_state_machine_test in CI remove dbg prints SQUASHED redelegation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on v0.23.0
Closes #34, closes #1829, closes #1830, closes #1556, closes #1959, closes #1640
Implements redelegation. We allow a delegator address to redelegate bonded tokens from one validator to another such that the bonded tokens will stop contributing to the original (source) validator's voting power and start contributing to the new (destination) validator's voting power at the pipeline epoch. Redelegated tokens remain slashable for unbonding length for any misbehavior committed by the source validator. Validator addresses can only bond to themselves and thus cannot redelegate.
Client cmd e.g.:
namadac redelegate --source-validator {} --destination-validator {} --owner {} --amount {}
Note that until we resolve informalsystems/partnership-heliax#74, multiple slashes per validator may result in overslashing, but this issue was already present before redelegation.
Notes on things to-do:
unbonds
andredelegated_unbonds
, ensure consistencyFurther testing goals:
test_multiple_misbehaviors
, with redelegations