Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor shielded sync #3006

Closed
wants to merge 29 commits into from

added print statements to try and debug in ci

bdb61c3
Select commit
Loading
Failed to load commit list.
Closed

Refactor shielded sync #3006

added print statements to try and debug in ci
bdb61c3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 4, 2024 in 0s

54.73% (+0.67%) compared to 883bd0f

View this Pull Request on Codecov

54.73% (+0.67%) compared to 883bd0f

Details

Codecov Report

Attention: Patch coverage is 46.65658% with 1763 lines in your changes missing coverage. Please review.

Project coverage is 54.73%. Comparing base (883bd0f) to head (bdb61c3).

Files Patch % Lines
crates/sdk/src/masp/shielded_ctx.rs 51.29% 844 Missing ⚠️
crates/sdk/src/masp/mod.rs 29.79% 436 Missing ⚠️
crates/sdk/src/masp/utils.rs 51.28% 208 Missing ⚠️
crates/apps_lib/src/client/masp.rs 0.00% 186 Missing ⚠️
crates/sdk/src/masp/types.rs 72.61% 43 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 27 Missing ⚠️
crates/sdk/src/masp/test_utils.rs 89.79% 15 Missing ⚠️
crates/apps_lib/src/cli/client.rs 0.00% 2 Missing ⚠️
crates/node/src/lib.rs 0.00% 1 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3006      +/-   ##
==========================================
+ Coverage   54.05%   54.73%   +0.67%     
==========================================
  Files         315      319       +4     
  Lines      106296   107702    +1406     
==========================================
+ Hits        57461    58952    +1491     
+ Misses      48835    48750      -85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.