Track caller's emitted events #3268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
force-pushed
the
tiago/track-caller-events
branch
from
430d746
to
83a3ef4
Compare
sug0
commented
May 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3268 +/- ##
==========================================
+ Coverage 53.79% 53.85% +0.06%
==========================================
Files 314 315 +1
Lines 105784 105987 +203
==========================================
+ Hits 56903 57083 +180
- Misses 48881 48904 +23 ☔ View full report in Codecov by Sentry. |
sug0
force-pushed
the
tiago/track-caller-events
branch
2 times, most recently
from
854703a
to
b5dd972
Compare
tzemanovic
reviewed
May 20, 2024
tzemanovic
previously approved these changes
May 20, 2024
sug0
force-pushed
the
tiago/track-caller-events
branch
from
ebbed13
to
73e0543
Compare
sug0
force-pushed
the
tiago/track-caller-events
branch
from
73e0543
to
11b9d05
Compare
brentstone
reviewed
May 21, 2024
|
|
||
| let trace = event.read_attribute::<EventOrigin>().unwrap(); | ||
|
|
||
| assert!(trace.line > start_line && trace.line < end_line); |
There was a problem hiding this comment.
nit: maybe trace.line == start_line + 1 && trace.line == END_LINE - 1?
There was a problem hiding this comment.
doesn't matter to be precise, we only care to check if the event was emitted within a certain region of the source code
sug0
force-pushed
the
tiago/track-caller-events
branch
from
11b9d05
to
df4b4f7
Compare
tzemanovic
added a commit
that referenced
this pull request
May 24, 2024
* origin/tiago/track-caller-events: Changelog for #3268 Activate `debug` feat when `testing` is active Test event emission origin Track the origin of emitted events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Track the source code origin of some emitted event in Namada.
Indicate on which release or other PRs this topic is based on
v0.36.1Checklist before merging to
draft