fix: allow governance to change ibc storage #3328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3328 +/- ##
==========================================
- Coverage 53.89% 53.88% -0.01%
==========================================
Files 314 314
Lines 105704 105736 +32
==========================================
+ Hits 56967 56977 +10
- Misses 48737 48759 +22 ☔ View full report in Codecov by Sentry. |
yito88
reviewed
May 29, 2024
|
|
||
| if is_governance_proposal { | ||
| let changed_keys_are_params = | ||
| keys_changed.iter().any(|key| is_ibc_key(key)); |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Indicate on which release or other PRs this topic is based on
Checklist before merging to
draft