Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve offline tx handling #3715

Merged
merged 9 commits into from
Sep 6, 2024

improve wallet support

34c6ac4
Select commit
Loading
Failed to load commit list.
Merged

improve offline tx handling #3715

improve wallet support
34c6ac4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 6, 2024 in 1s

72.68% (+0.19%) compared to 521511f

View this Pull Request on Codecov

72.68% (+0.19%) compared to 521511f

Details

Codecov Report

Attention: Patch coverage is 86.48649% with 20 lines in your changes missing coverage. Please review.

Project coverage is 72.68%. Comparing base (521511f) to head (34c6ac4).

Files with missing lines Patch % Lines
crates/core/src/key/common.rs 79.48% 8 Missing ⚠️
crates/core/src/hash.rs 84.84% 5 Missing ⚠️
crates/tx/src/lib.rs 91.37% 5 Missing ⚠️
crates/sdk/src/tx.rs 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3715      +/-   ##
==========================================
+ Coverage   72.49%   72.68%   +0.19%     
==========================================
  Files         338      338              
  Lines      104190   104309     +119     
==========================================
+ Hits        75535    75822     +287     
+ Misses      28655    28487     -168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.