Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the signing logic to fall back to the hardware wallet if secret key is not found. #3730

Merged
merged 3 commits into from
Sep 8, 2024

Ensure that the number of used public keys exceeds the account thresh…

24e790a
Select commit
Loading
Failed to load commit list.
Merged

Enable the signing logic to fall back to the hardware wallet if secret key is not found. #3730

Ensure that the number of used public keys exceeds the account thresh…
24e790a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 8, 2024 in 1s

72.69% (+0.00%) compared to 0d7140f

View this Pull Request on Codecov

72.69% (+0.00%) compared to 0d7140f

Details

Codecov Report

Attention: Patch coverage is 38.46154% with 16 lines in your changes missing coverage. Please review.

Project coverage is 72.69%. Comparing base (0d7140f) to head (24e790a).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/signing.rs 38.46% 16 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3730   +/-   ##
=======================================
  Coverage   72.68%   72.69%           
=======================================
  Files         338      338           
  Lines      104319   104339   +20     
=======================================
+ Hits        75826    75849   +23     
+ Misses      28493    28490    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov