Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MASP SDK Refactor #3744

Merged
merged 18 commits into from
Sep 6, 2024
Merged

MASP SDK Refactor #3744

merged 18 commits into from
Sep 6, 2024

Conversation

batconjurer
Copy link
Member

Factored most of the masp code out of the sdk and into shielded token crate

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@batconjurer batconjurer marked this pull request as draft September 3, 2024 10:00
@batconjurer batconjurer marked this pull request as ready for review September 4, 2024 10:00
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 77.32164% with 569 lines in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (c7f6a80) to head (87675d5).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
crates/io/src/client.rs 2.55% 191 Missing ⚠️
crates/shielded_token/src/masp/shielded_wallet.rs 87.21% 164 Missing ⚠️
crates/shielded_token/src/masp.rs 81.34% 105 Missing ⚠️
crates/sdk/src/rpc.rs 64.61% 23 Missing ⚠️
...hielded_token/src/masp/shielded_sync/dispatcher.rs 53.06% 23 Missing ⚠️
crates/sdk/src/masp/utilities.rs 67.30% 17 Missing ⚠️
crates/sdk/src/tx.rs 40.74% 16 Missing ⚠️
crates/token/src/lib.rs 0.00% 13 Missing ⚠️
...tes/shielded_token/src/masp/shielded_sync/utils.rs 95.61% 10 Missing ⚠️
crates/shielded_token/src/masp/test_utils.rs 55.55% 4 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3744      +/-   ##
==========================================
- Coverage   72.42%   72.41%   -0.01%     
==========================================
  Files         335      339       +4     
  Lines      104005   104006       +1     
==========================================
- Hits        75322    75313       -9     
- Misses      28683    28693      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/node/Cargo.toml Outdated Show resolved Hide resolved
crates/node/Cargo.toml Outdated Show resolved Hide resolved
crates/tests/Cargo.toml Outdated Show resolved Hide resolved
batconjurer and others added 8 commits September 5, 2024 14:33
Co-authored-by: Tomas Zemanovic <[email protected]>
Co-authored-by: Tomas Zemanovic <[email protected]>
Co-authored-by: Tomas Zemanovic <[email protected]>
Co-authored-by: Tomas Zemanovic <[email protected]>
Co-authored-by: Tomas Zemanovic <[email protected]>
Co-authored-by: Tomas Zemanovic <[email protected]>
Co-authored-by: Tomas Zemanovic <[email protected]>
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 5, 2024
mergify bot added a commit that referenced this pull request Sep 5, 2024
Copy link
Contributor

mergify bot commented Sep 5, 2024

Hey @batconjurer, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Member

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Sep 6, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Sep 6, 2024
@mergify mergify bot merged commit 98437ef into main Sep 6, 2024
22 of 23 checks passed
@mergify mergify bot deleted the bat/sdk-masp-refactor branch September 6, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants