Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue: embarking main (ac24f58) and #3744 together #3759

Closed
wants to merge 19 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 5, 2024

❌ This pull request has failed checks. #3744 will be removed from the queue. ❌

Branch main (ac24f58) and #3744 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #3744.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue main-queue for merge:

  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (2)
    • check-skipped=test-e2e (2)
    • check-success=test-e2e (2)
  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-neutral=Mergify Merge Protections
    • check-skipped=Mergify Merge Protections
    • check-success=Mergify Merge Protections
  • any of [🛡 GitHub branch protection]:
    • check-success=check-benchmarks
    • check-neutral=check-benchmarks
    • check-skipped=check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-success=check-packages
    • check-neutral=check-packages
    • check-skipped=check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success=build-binaries
    • check-neutral=build-binaries
    • check-skipped=build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-neutral=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-skipped=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
  • any of [🛡 GitHub branch protection]:
    • check-success=lints
    • check-neutral=lints
    • check-skipped=lints
  • any of [🛡 GitHub branch protection]:
    • check-success=test-unit
    • check-neutral=test-unit
    • check-skipped=test-unit
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (0)
    • check-neutral=test-e2e (0)
    • check-skipped=test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (1)
    • check-neutral=test-e2e (1)
    • check-skipped=test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (3)
    • check-neutral=test-e2e (3)
    • check-skipped=test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (4)
    • check-neutral=test-e2e (4)
    • check-skipped=test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-integration
    • check-neutral=test-integration
    • check-skipped=test-integration
  • any of [🛡 GitHub branch protection]:
    • check-success=test-wasm
    • check-neutral=test-wasm
    • check-skipped=test-wasm

Required conditions to stay in the queue:

---
previous_failed_batches: []
pull_requests:
  - number: 3744
...

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 77.32164% with 569 lines in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (ac24f58) to head (07749a1).

Files with missing lines Patch % Lines
crates/io/src/client.rs 2.55% 191 Missing ⚠️
crates/shielded_token/src/masp/shielded_wallet.rs 87.21% 164 Missing ⚠️
crates/shielded_token/src/masp.rs 81.34% 105 Missing ⚠️
crates/sdk/src/rpc.rs 64.61% 23 Missing ⚠️
...hielded_token/src/masp/shielded_sync/dispatcher.rs 53.06% 23 Missing ⚠️
crates/sdk/src/masp/utilities.rs 67.30% 17 Missing ⚠️
crates/sdk/src/tx.rs 40.74% 16 Missing ⚠️
crates/token/src/lib.rs 0.00% 13 Missing ⚠️
...tes/shielded_token/src/masp/shielded_sync/utils.rs 95.61% 10 Missing ⚠️
crates/shielded_token/src/masp/test_utils.rs 55.55% 4 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3759      +/-   ##
==========================================
- Coverage   72.41%   72.41%   -0.01%     
==========================================
  Files         335      339       +4     
  Lines      104005   104006       +1     
==========================================
- Hits        75320    75313       -7     
- Misses      28685    28693       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot closed this Sep 5, 2024
@mergify mergify bot deleted the mergify/merge-queue/4d976a5512 branch September 5, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant