Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx & VP ctx and tests refactors #3787

Closed
wants to merge 2 commits into from
Closed

tx & VP ctx and tests refactors #3787

wants to merge 2 commits into from

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Sep 8, 2024

Describe your changes

Depends-On: #3807

  • moved Ctx from tx_prelude into tx_env to declare & implement trait TxEnv in one crate so that it can be tested without additional deps

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 86.08247% with 54 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (1008f60) to head (e73c499).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
crates/tx_env/src/ctx.rs 82.88% 45 Missing ⚠️
crates/tx_prelude/src/proof_of_stake.rs 75.00% 3 Missing ⚠️
wasm/vp_implicit/src/lib.rs 90.90% 2 Missing ⚠️
crates/tx_prelude/src/ibc.rs 90.00% 1 Missing ⚠️
wasm/tx_change_consensus_key/src/lib.rs 0.00% 1 Missing ⚠️
wasm/tx_change_validator_metadata/src/lib.rs 0.00% 1 Missing ⚠️
wasm/tx_claim_rewards/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3787      +/-   ##
==========================================
+ Coverage   72.68%   72.75%   +0.06%     
==========================================
  Files         338      340       +2     
  Lines      104340   104723     +383     
==========================================
+ Hits        75837    76187     +350     
- Misses      28503    28536      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic mentioned this pull request Sep 12, 2024
1 task
Copy link
Contributor

mergify bot commented Sep 12, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant