-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable-6] Add github workflows (sanity, units, linters and changelog) #1672
Merged
alinabuzachis
merged 4 commits into
ansible-collections:stable-6
from
alinabuzachis:add_github_workflows_stable-6
Aug 1, 2023
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
--- | ||
name: all_green | ||
|
||
concurrency: | ||
group: ${{ github.head_ref }} | ||
cancel-in-progress: true | ||
|
||
on: # yamllint disable-line rule:truthy | ||
pull_request: | ||
types: | ||
- opened | ||
- reopened | ||
- labeled | ||
- unlabeled | ||
- synchronize | ||
branches: | ||
- main | ||
- 'stable-*' | ||
tags: | ||
- '*' | ||
|
||
jobs: | ||
changelog-and-linters: | ||
uses: ./.github/workflows/changelog_and_linters.yml # use the callable changelog-and-linters job to run tests | ||
sanity: | ||
uses: ./.github/workflows/sanity.yml # use the callable sanity job to run tests | ||
units: | ||
uses: ./.github/workflows/units.yml # use the callable units job to run tests | ||
all_green: | ||
if: ${{ always() }} | ||
needs: | ||
- changelog-and-linters | ||
- sanity | ||
- units | ||
runs-on: ubuntu-latest | ||
steps: | ||
- run: >- | ||
python -c "assert set([ | ||
'${{ needs.changelog-and-linters.result }}', | ||
'${{ needs.sanity.result }}', | ||
'${{ needs.units.result }}' | ||
]) == {'success'}" |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
name: changelog and linters | ||
|
||
on: [workflow_call] # allow this workflow to be called from other workflows | ||
|
||
jobs: | ||
changelog: | ||
uses: ansible-network/github_actions/.github/workflows/changelog.yml@main | ||
linters: | ||
uses: ansible-network/github_actions/.github/workflows/tox-linters.yml@main |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
--- | ||
name: sanity tests | ||
|
||
on: [workflow_call] # allow this workflow to be called from other workflows | ||
|
||
jobs: | ||
sanity: | ||
uses: ansible-network/github_actions/.github/workflows/sanity.yml@main | ||
with: | ||
matrix_include: "[]" | ||
matrix_exclude: >- | ||
[ | ||
{ | ||
"ansible-version": "stable-2.9" | ||
}, | ||
{ | ||
"ansible-version": "stable-2.12", | ||
"python-version": "3.7" | ||
}, | ||
{ | ||
"ansible-version": "stable-2.12", | ||
"python-version": "3.11" | ||
}, | ||
{ | ||
"ansible-version": "stable-2.13", | ||
"python-version": "3.7" | ||
}, | ||
{ | ||
"ansible-version": "stable-2.13", | ||
"python-version": "3.11" | ||
}, | ||
{ | ||
"ansible-version": "stable-2.14", | ||
"python-version": "3.7" | ||
}, | ||
{ | ||
"ansible-version": "stable-2.14", | ||
"python-version": "3.8" | ||
}, | ||
{ | ||
"ansible-version": "stable-2.15", | ||
"python-version": "3.7" | ||
}, | ||
{ | ||
"ansible-version": "stable-2.15", | ||
"python-version": "3.8" | ||
}, | ||
{ | ||
"ansible-version": "milestone", | ||
"python-version": "3.7" | ||
}, | ||
{ | ||
"ansible-version": "milestone", | ||
"python-version": "3.8" | ||
}, | ||
{ | ||
"ansible-version": "milestone", | ||
"python-version": "3.9" | ||
}, | ||
{ | ||
"ansible-version": "devel", | ||
"python-version": "3.7" | ||
}, | ||
{ | ||
"ansible-version": "devel", | ||
"python-version": "3.8" | ||
}, | ||
{ | ||
"ansible-version": "devel", | ||
"python-version": "3.9" | ||
} | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
name: unit tests | ||
|
||
on: [workflow_call] # allow this workflow to be called from other workflows | ||
|
||
jobs: | ||
unit-source: | ||
uses: ansible-network/github_actions/.github/workflows/unit_source.yml@main |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
trivial: | ||
- "Add sanity, units and linters and changelog GitHub workflows." |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this triggers are impacting
changelog
workflow only, we should create a different file for that and all_green does not need to changelog being success as this will fail automaticallyanyway we can keep it like that as it is already like this in the main branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this is merged, if you want, you can open a PR against main and backport to stable-6 and stable-5 this way we ensure consistency between branches.