-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable-6] Add github workflows (sanity, units, linters and changelog) #1672
[stable-6] Add github workflows (sanity, units, linters and changelog) #1672
Conversation
Manually merged (.github/)
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 17s |
.github/workflows/units.yml
Outdated
unit-source: | ||
uses: ansible-network/github_actions/.github/workflows/unit_source.yml@main | ||
with: | ||
matrix_exclude: >- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually need this anymore? It seems like we should be able to just use the default excludes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to add the only ones non listed https://github.com/ansible-network/github_actions/blob/main/.github/workflows/unit_source.yml and https://github.com/ansible-network/github_actions/blob/main/.github/workflows/sanity.yml. Correct me if I am wrong. I will prepare a PR for the other branches too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change won't work because changes in this repo aren't merged with the defaults, they completely overwrite. What I'm suggesting is that we just don't provide a matrix_exclude
at all for the unit test workflow and just use whatever that action defaults to. I don't think we can do the same yet for sanity because of ansible 2.9.
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 6m 22s |
- labeled | ||
- unlabeled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this triggers are impacting changelog
workflow only, we should create a different file for that and all_green does not need to changelog being success as this will fail automatically
anyway we can keep it like that as it is already like this in the main branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this is merged, if you want, you can open a PR against main and backport to stable-6 and stable-5 this way we ensure consistency between branches.
SUMMARY
Add github workflows to stable-6
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION