Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-6] Add github workflows (sanity, units, linters and changelog) #1672

Conversation

alinabuzachis
Copy link
Contributor

SUMMARY

Add github workflows to stable-6

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Manually merged (.github/)
@alinabuzachis alinabuzachis changed the title [stable-6] Add github workflow [stable-6] Add github workflows (sanity, units, linters and changelog) Jul 31, 2023
@softwarefactory-project-zuul
Copy link
Contributor

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review needs_triage labels Jul 31, 2023
unit-source:
uses: ansible-network/github_actions/.github/workflows/unit_source.yml@main
with:
matrix_exclude: >-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need this anymore? It seems like we should be able to just use the default excludes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add the only ones non listed https://github.com/ansible-network/github_actions/blob/main/.github/workflows/unit_source.yml and https://github.com/ansible-network/github_actions/blob/main/.github/workflows/sanity.yml. Correct me if I am wrong. I will prepare a PR for the other branches too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change won't work because changes in this repo aren't merged with the defaults, they completely overwrite. What I'm suggesting is that we just don't provide a matrix_exclude at all for the unit test workflow and just use whatever that action defaults to. I don't think we can do the same yet for sanity because of ansible 2.9.

Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Comment on lines +13 to +14
- labeled
- unlabeled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this triggers are impacting changelog workflow only, we should create a different file for that and all_green does not need to changelog being success as this will fail automatically
anyway we can keep it like that as it is already like this in the main branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is merged, if you want, you can open a PR against main and backport to stable-6 and stable-5 this way we ensure consistency between branches.

@alinabuzachis alinabuzachis merged commit 568c08d into ansible-collections:stable-6 Aug 1, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants