[stable-6] Add github workflows (sanity, units, linters and changelog) #1672
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| --- | ||
| name: all_green | ||
|
|
||
| concurrency: | ||
| group: ${{ github.head_ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| on: # yamllint disable-line rule:truthy | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - reopened | ||
| - labeled | ||
| - unlabeled | ||
| - synchronize | ||
| branches: | ||
| - main | ||
| - 'stable-*' | ||
| tags: | ||
| - '*' | ||
|
|
||
| jobs: | ||
| changelog-and-linters: | ||
| uses: ./.github/workflows/changelog_and_linters.yml # use the callable changelog-and-linters job to run tests | ||
| sanity: | ||
| uses: ./.github/workflows/sanity.yml # use the callable sanity job to run tests | ||
| units: | ||
| uses: ./.github/workflows/units.yml # use the callable units job to run tests | ||
| all_green: | ||
| if: ${{ always() }} | ||
| needs: | ||
| - changelog-and-linters | ||
| - sanity | ||
| - units | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - run: >- | ||
| python -c "assert set([ | ||
| '${{ needs.changelog-and-linters.result }}', | ||
| '${{ needs.sanity.result }}', | ||
| '${{ needs.units.result }}' | ||
| ]) == {'success'}" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| name: changelog and linters | ||
|
|
||
| on: [workflow_call] # allow this workflow to be called from other workflows | ||
|
|
||
| jobs: | ||
| changelog: | ||
| uses: ansible-network/github_actions/.github/workflows/changelog.yml@main | ||
| linters: | ||
| uses: ansible-network/github_actions/.github/workflows/tox-linters.yml@main |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| --- | ||
| name: sanity tests | ||
|
|
||
| on: [workflow_call] # allow this workflow to be called from other workflows | ||
|
|
||
| jobs: | ||
| sanity: | ||
| uses: ansible-network/github_actions/.github/workflows/sanity.yml@main | ||
| with: | ||
| matrix_include: "[]" | ||
| matrix_exclude: >- | ||
| [ | ||
| { | ||
| "ansible-version": "stable-2.9" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.12", | ||
| "python-version": "3.7" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.12", | ||
| "python-version": "3.11" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.13", | ||
| "python-version": "3.7" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.13", | ||
| "python-version": "3.11" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.14", | ||
| "python-version": "3.7" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.14", | ||
| "python-version": "3.8" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.15", | ||
| "python-version": "3.7" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.15", | ||
| "python-version": "3.8" | ||
| }, | ||
| { | ||
| "ansible-version": "milestone", | ||
| "python-version": "3.7" | ||
| }, | ||
| { | ||
| "ansible-version": "milestone", | ||
| "python-version": "3.8" | ||
| }, | ||
| { | ||
| "ansible-version": "devel", | ||
| "python-version": "3.7" | ||
| }, | ||
| { | ||
| "ansible-version": "devel", | ||
| "python-version": "3.8" | ||
| }, | ||
| { | ||
| "ansible-version": "devel", | ||
| "python-version": "3.9" | ||
| } | ||
| ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| --- | ||
| name: unit tests | ||
|
|
||
| on: [workflow_call] # allow this workflow to be called from other workflows | ||
|
|
||
| jobs: | ||
| unit-source: | ||
| uses: ansible-network/github_actions/.github/workflows/unit_source.yml@main | ||
| with: | ||
| matrix_exclude: >- | ||
|
There was a problem hiding this comment. Do we actually need this anymore? It seems like we should be able to just use the default excludes. There was a problem hiding this comment. I tried to add the only ones non listed https://github.com/ansible-network/github_actions/blob/main/.github/workflows/unit_source.yml and https://github.com/ansible-network/github_actions/blob/main/.github/workflows/sanity.yml. Correct me if I am wrong. I will prepare a PR for the other branches too. There was a problem hiding this comment. This change won't work because changes in this repo aren't merged with the defaults, they completely overwrite. What I'm suggesting is that we just don't provide a |
||
| [ | ||
| { | ||
| "python-version": "3.11" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.12", | ||
| "python-version": "3.7" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.13", | ||
| "python-version": "3.7" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.12", | ||
| "python-version": "3.8" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.13", | ||
| "python-version": "3.8" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.14", | ||
| "python-version": "3.7" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.14", | ||
| "python-version": "3.8" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.15", | ||
| "python-version": "3.7" | ||
| }, | ||
| { | ||
| "ansible-version": "stable-2.15", | ||
| "python-version": "3.8" | ||
| }, | ||
| { | ||
| "ansible-version": "milestone", | ||
| "python-version": "3.7" | ||
| }, | ||
| { | ||
| "ansible-version": "milestone", | ||
| "python-version": "3.8" | ||
| }, | ||
| { | ||
| "ansible-version": "devel", | ||
| "python-version": "3.7" | ||
| }, | ||
| { | ||
| "ansible-version": "devel", | ||
| "python-version": "3.8" | ||
| }, | ||
| { | ||
| "ansible-version": "devel", | ||
| "python-version": "3.9" | ||
| } | ||
| ] | ||
| collection_pre_install: '' | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| trivial: | ||
| - "Add sanity, units and linters and changelog GitHub workflows." |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this triggers are impacting
changelogworkflow only, we should create a different file for that and all_green does not need to changelog being success as this will fail automaticallyanyway we can keep it like that as it is already like this in the main branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this is merged, if you want, you can open a PR against main and backport to stable-6 and stable-5 this way we ensure consistency between branches.