Rename smoke-tests into build-wheelhouse in the common ci_cd.yml template
#492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…}}/.github/workflows/ci_cd.yml`: rename `smoke-tests` into `build-wheelhouse`
2 tasks
…}}/.github/workflows/ci_cd.yml`: `release-github`: `needs: [doc-build, build-wheelhouse, release-pypi-private]`
anscfrisson
commented
Jun 20, 2024
| @@ -225,7 +225,7 @@ jobs: | |||
| release-github: | |||
| name: "Release to GitHub" | |||
| runs-on: ubuntu-latest | |||
| needs: [doc-build, release-pypi-private] | |||
There was a problem hiding this comment.
Also adding build-wheelhouse to tests needs:
- needs: [doc-build, release-pypi-private]
+ needs: [doc-build, build-wheelhouse, release-pypi-private]Because in https://github.com/ansys-internal/simba-core/actions/runs/9600322073/attempts/1 even if jobs Build and Smoke tests (ubuntu-latest, 3.10) and Build and Smoke tests (windows-latest, 3.10) generated ansys-simba-core-v0.16.0-wheelhouse-ubuntu-latest-3.10 and ansys-simba-core-v0.16.0-wheelhouse-windows-latest-3.10, Release to GitHub failed to find the wheelhouse files at it was run without dependency to the Build and Smoke tests jobs. This is proven by re-running Release to GitHub which then found the wheelhouse files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #491