Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename smoke-tests into build-wheelhouse in the common ci_cd.yml template #492

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Rename smoke-tests into build-wheelhouse in the common ci_cd.yml template #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e0c356
`src/ansys/templates/python/common/{{cookiecutter.__project_name_slug…
anscfrisson Jun 20, 2024
996f31c
Adding changelog entry: 492.miscellaneous.md
pyansys-ci-bot Jun 20, 2024
fed8ef7
`src/ansys/templates/python/common/{{cookiecutter.__project_name_slug…
anscfrisson Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/492.miscellaneous.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Rename `smoke-tests` into `build-wheelhouse` in the common `ci_cd.yml` template
8 changes: 4 additions & 4 deletions .../templates/python/common/{{cookiecutter.__project_name_slug}}/.github/workflows/ci_cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ jobs:
with:
token: {{ '${{ secrets.GITHUB_TOKEN }}' }}

smoke-tests:
name: "Build and Smoke tests"
build-wheelhouse:
name: "Build wheelhouse"
runs-on: {{ '${{ matrix.os }}' }}
needs: [code-style]
strategy:
Expand All @@ -75,7 +75,7 @@ jobs:
tests:
name: "Tests"
runs-on: {{ '${{ matrix.os }}' }}
needs: [smoke-tests]
needs: [build-wheelhouse]
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
Expand Down Expand Up @@ -225,7 +225,7 @@ jobs:
release-github:
name: "Release to GitHub"
runs-on: ubuntu-latest
needs: [doc-build, release-pypi-private]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also adding build-wheelhouse to tests needs:

-    needs: [doc-build, release-pypi-private]
+    needs: [doc-build, build-wheelhouse, release-pypi-private]

Because in https://github.com/ansys-internal/simba-core/actions/runs/9600322073/attempts/1 even if jobs Build and Smoke tests (ubuntu-latest, 3.10) and Build and Smoke tests (windows-latest, 3.10) generated ansys-simba-core-v0.16.0-wheelhouse-ubuntu-latest-3.10 and ansys-simba-core-v0.16.0-wheelhouse-windows-latest-3.10, Release to GitHub failed to find the wheelhouse files at it was run without dependency to the Build and Smoke tests jobs. This is proven by re-running Release to GitHub which then found the wheelhouse files.

needs: [doc-build, build-wheelhouse, release-pypi-private]
steps:
- name: "Release to GitHub"
if: github.event_name == 'push' && contains(github.ref, 'refs/tags')
Expand Down
Loading