Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: VSin, ISin Sources added to Maxwell Circuit Primitives #5283
base: main
Are you sure you want to change the base?
FEAT: VSin, ISin Sources added to Maxwell Circuit Primitives #5283
Changes from 22 commits
5aac760
f8699a5
8552947
93375bd
955bcf7
cf6153e
eb4c79e
a07645f
84e4f7a
d7945da
a3a2340
46152e2
bf84832
0c4d246
d180ad8
5a95e4e
4b7d09f
f00f682
359f752
fdf3786
4ef9e9f
d44fd5d
0a98ed1
a4dd34f
7aa718d
bd322c4
44827f3
29eeb97
3f56946
e053aab
8cefb93
44c9258
8b94bd1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1291 in src/ansys/aedt/core/modeler/circuits/primitives_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_circuit.py#L1287-L1291
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to add
nb_pages
as a property instead of adding this feature as a method.Check warning on line 1312 in src/ansys/aedt/core/modeler/circuits/primitives_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_circuit.py#L1311-L1312
Check warning on line 112 in src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py#L112
Check warning on line 123 in src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py#L120-L123
Check warning on line 155 in src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py#L155
Check warning on line 167 in src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py#L164-L167
Check warning on line 198 in src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py#L198
Check warning on line 210 in src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py#L207-L210
Check warning on line 240 in src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py#L240
Check warning on line 251 in src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py#L249-L251
Check warning on line 280 in src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py#L280
Check warning on line 290 in src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py#L288-L290
Check warning on line 320 in src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py#L318-L320
Check warning on line 332 in src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py#L329-L332
Check warning on line 362 in src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py#L360-L362
Check warning on line 374 in src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py
Codecov / codecov/patch
src/ansys/aedt/core/modeler/circuits/primitives_maxwell_circuit.py#L371-L374