feat(go/adbc/driver/snowflake): add query tag option #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets you identify particular queries in the query history. Fixes apache#1934.
zeroshade
reviewed
Jan 27, 2025
Comment on lines
+2268
to
+2270
| rdr, n, err := suite.stmt.ExecuteQuery(suite.ctx) | ||
| suite.Require().NoError(err) | ||
| defer rdr.Release() |
There was a problem hiding this comment.
i doubt it, but is there any way we can test / confirm that the tag is being propagated for the query?
There was a problem hiding this comment.
That is the test: we query the query history with the tag and make sure it comes back
There was a problem hiding this comment.
Ah i get it. I missed that's what the query below was doing. Makes sense! Thanks!
zeroshade
reviewed
Jan 27, 2025
Comment on lines
+115
to
+117
| #: An identifier for a query/queries that can be used to find the query in | ||
| #: the query history. Use a blank string to unset the tag. | ||
| QUERY_TAG = "adbc.snowflake.statement.query_tag" |
There was a problem hiding this comment.
did we ever update the docs to point out the difference between statement options and connection options etc.?
There was a problem hiding this comment.
I don't think so. In general I'd like to improve the docs...
zeroshade
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets you identify particular queries in the query history.
Fixes #1934.