-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(go/adbc/driver/snowflake): add query tag option #2484
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -112,6 +112,9 @@ class StatementOptions(enum.Enum): | |
#: Number of concurrent streams being prefetched for a result set. | ||
#: Defaults to 10. | ||
PREFETCH_CONCURRENCY = "adbc.snowflake.rpc.prefetch_concurrency" | ||
#: An identifier for a query/queries that can be used to find the query in | ||
#: the query history. Use a blank string to unset the tag. | ||
QUERY_TAG = "adbc.snowflake.statement.query_tag" | ||
Comment on lines
+115
to
+117
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. did we ever update the docs to point out the difference between statement options and connection options etc.? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think so. In general I'd like to improve the docs... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
#: Number of parquet files to write in parallel for bulk ingestion | ||
#: Defaults to NumCPU | ||
INGEST_WRITER_CONCURRENCY = "adbc.snowflake.statement.ingest_writer_concurrency" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i doubt it, but is there any way we can test / confirm that the tag is being propagated for the query?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the test: we query the query history with the tag and make sure it comes back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah i get it. I missed that's what the query below was doing. Makes sense! Thanks!